feat: support glob patterns #151
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We use a weird mix of multiple glob patterns and ignores which means we parse the available files in an inefficient way. Instead just use a single glob pattern which can do everything we need. Fixes ipfs/js-ipfs#2885
alanshaw
reviewed
Sep 21, 2021
src/files/glob-source.js
Outdated
| const absolutePath = Path.resolve(process.cwd(), path) | ||
| const stat = await fsp.stat(absolutePath) | ||
| const prefix = Path.dirname(absolutePath) | ||
| const globOptions = Object.assign({}, pattern, { |
There was a problem hiding this comment.
Pattern is a string no? Why assigning options to it?
src/files/glob-source.js
Outdated
| ) | ||
| } | ||
| if (pattern.startsWith('.' + Path.sep)) { | ||
| pattern = pattern.replace('.' + Path.sep, '') |
There was a problem hiding this comment.
What does this bit guard against?
There was a problem hiding this comment.
With hindsight I don't think it's necessary, I've removed it.
alanshaw
reviewed
Sep 21, 2021
src/files/glob-source.js
Outdated
| * @param {boolean} [options.followSymlinks] - follow symlinks | ||
| * @param {boolean} [options.preserveMode] - preserve mode | ||
| * @param {boolean} [options.preserveMtime] - preserve mtime | ||
| * @param {number} [options.mode] - mode to use - if preserveMode is true this will be ignored | ||
| * @param {import('ipfs-unixfs').MtimeLike} [options.mtime] - mtime to use - if preserveMtime is true this will be ignored | ||
| * @yields {Object} File objects in the form `{ path: String, content: AsyncIterator<Buffer> }` | ||
| */ | ||
| module.exports = async function * globSource (paths, options) { | ||
| module.exports = async function * globSource (pattern, options) { |
There was a problem hiding this comment.
I'd be tempted to make this take cwd, pattern, options to avoid some of the cwd messing around bits.
There was a problem hiding this comment.
Done, I'm, always wondering where the output path will start.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We use a weird mix of multiple glob patterns and ignores which means we parse the available files in an inefficient way.
Instead just use a single glob pattern which can do everything we need.
Fixes ipfs/js-ipfs#2885
BREAKING CHANGE: the globSource call signature has changed and no longer supports the recursive or ignore options